benwtrent commented on code in PR #12657:
URL: https://github.com/apache/lucene/pull/12657#discussion_r1358794152
##########
lucene/core/src/test/org/apache/lucene/util/hnsw/HnswGraphTestCase.java:
##########
@@ -1147,15 +1139,15 @@ void assertVectorsEqual(AbstractMockVectorValues<T> u,
AbstractMockVectorValues<
static float[][] createRandomFloatVectors(int size, int dimension, Random
random) {
float[][] vectors = new float[size][];
- for (int offset = 0; offset < size; offset += random.nextInt(3) + 1) {
+ for (int offset = 0; offset < size; offset++) {
Review Comment:
I think this was to simulate sparse vectors. But the sparse vector iterator
never returns `null` for the vectors. Instead it just skips to the next
non-null vector from what I can tell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
