jpountz commented on code in PR #12682:
URL: https://github.com/apache/lucene/pull/12682#discussion_r1361739665
##########
lucene/core/src/java/org/apache/lucene/search/ReqOptSumScorer.java:
##########
@@ -266,7 +265,7 @@ public float score() throws IOException {
score += optScorer.score();
}
- return score;
+ return (float) score;
Review Comment:
I think that the TODO still makes sense, it refers to BS1 being able to
handle a mix of MUST and SHOULD clauses. If it happened, then it could have
more than 2 clauses so casting into a double would make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
