dungba88 commented on code in PR #12709:
URL: https://github.com/apache/lucene/pull/12709#discussion_r1369373040
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -317,8 +319,6 @@ private CompiledNode compileNode(UnCompiledNode<T> nodeIn,
int tailLength) throw
// serializes new node by appending its bytes to the end
// of the current byte[]
long addNode(FSTCompiler.UnCompiledNode<T> nodeIn) throws IOException {
- T NO_OUTPUT = fst.outputs.getNoOutput();
Review Comment:
Technically it was not dead code but we already kept the `NO_OUTPUT` as
property of `FSTCompiler`, and since it is an immutable property of Outputs
there is no need to reassign it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
