javanna commented on code in PR #12718:
URL: https://github.com/apache/lucene/pull/12718#discussion_r1369871488
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -425,11 +425,12 @@ public int count(Query query) throws IOException {
}
/**
- * Returns the leaf slices used for concurrent searching
+ * Returns the leaf slices used for concurrent searching. Override {@link
#slices(List)} to
+ * customize how slices are created.
*
* @lucene.experimental
*/
- public LeafSlice[] getSlices() {
+ public final LeafSlice[] getSlices() {
Review Comment:
I wonder if we are good backporting this to 9.x given that the method is
experimental. I don't see a reason why one would override getSlices on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
