mayya-sharipova commented on code in PR #12794:
URL: https://github.com/apache/lucene/pull/12794#discussion_r1403551939
##########
lucene/core/src/java/org/apache/lucene/search/TopKnnCollector.java:
##########
@@ -26,26 +26,71 @@
* @lucene.experimental
*/
public final class TopKnnCollector extends AbstractKnnCollector {
+ private static final float DEFAULT_GREEDINESS = 0.9f;
Review Comment:
@vigyasharma Thanks for your feedback. Indeed, more documentation is
needed, I will add it after we finalize the experiments.
A general idea with the introduction of a second shorter local queue is
that different searches from different graphs can progress differently. We
don't want to stop searching a graph if we are just starting and still in a bad
neighbourhood where similarity can be worse that the globally collected
results. We still want to make some progress.
As you correctly noticed, `greediness` is meant to show how greedy is our
local segment based search if we are not competitive globally. A good approach
could be to be greedy, and don't do much exploration in this case, keeping
size of the second queue small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
