mikemccand commented on code in PR #12876:
URL: https://github.com/apache/lucene/pull/12876#discussion_r1418816397
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -97,11 +96,11 @@
*/
public final class CheckIndex implements Closeable {
+ private final Directory dir;
+ private final Lock writeLock;
Review Comment:
Ahh thanks for adding missing `final` tags too. I wish we had a static
checker for this.
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -3216,11 +3213,11 @@ public static Status.DocValuesStatus testDocValues(
}
@FunctionalInterface
- private static interface DocValuesIteratorSupplier {
Review Comment:
Heh, the other PR about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
