mikemccand commented on code in PR #12966:
URL: https://github.com/apache/lucene/pull/12966#discussion_r1444557053
##########
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java:
##########
@@ -202,7 +202,7 @@ public FacetResult getTopChildren(int topN, String dim,
String... path) throws I
}
reuse = q.insertWithOverflow(reuse);
if (q.size() == topN) {
- bottomCount = q.top().value;
+ bottomCount = (int) q.top().value;
Review Comment:
Hmm why is this cast necessary? Oh -- I see, this `value` is now a
`Number`. Hence the warning about added boxing/unboxing in hotspots here...
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
