dweiss commented on code in PR #12982:
URL: https://github.com/apache/lucene/pull/12982#discussion_r1445882248
##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Exception {
PrefixCompletionQuery query =
new PrefixCompletionQuery(analyzer, new Term("suggest_field", "abc_"));
TopSuggestDocs suggest = indexSearcher.suggest(query, numLive, false);
- assertSuggestions(suggest, expectedEntries.toArray(new
Entry[expectedEntries.size()]));
+ assertSuggestions(suggest, expectedEntries.toArray(new Entry[0]));
Review Comment:
Given the number of use cases, I'd go with option 3 or 1 - maybe I'm overly
sensitive about that new Foo[0]...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
