romseygeek commented on PR #12938: URL: https://github.com/apache/lucene/pull/12938#issuecomment-1898672394
This seems reasonable - FunctionQuery doesn't actually match things, it just scores, so it shouldn't be used for highlighting in any case. Could you add a test to the highlighting module showing that including a FunctionQuery as a clause in a boolean query that has other highlightable clauses doesn't prevent those clauses from being correctly highlighted? It might also be worth pulling the set of queries that get visited via `visitLeaf()` but are not unrecognized into an explicit set which we check, rather than using a list of `instanceof` clauses which might get longer in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
