benwtrent commented on PR #13058: URL: https://github.com/apache/lucene/pull/13058#issuecomment-1921169639
> "exactly visitLimit hits have been collected but I collected all that I needed" and "exactly visitLimit hits have been collected but I would need to collect more to be done"? @jpountz I suppose the key thing is that the collector doesn't know if more candidates were left to explore. Being able to tell it this would extend its API and require some more code changed in the searcher. Basically, "earlyTerminated" would no longer be tied to numVisited, but whatever is doing the exploring would have to increment the visited count and when the visit limit is reached flag "earlyTerminated" if indeed it did. This seems like a bigger complication to me with little benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
