ChrisHegarty commented on PR #13196: URL: https://github.com/apache/lucene/pull/13196#issuecomment-2016589340
> At a later stage we can ... > > I can do this later. OK? This seems quite reasonable to me. Native access should be as close to a wrapper around the native functions as possible, so should look and feel familiar to the reader of the code. As it stands this PR is a significant step forward, we should merge it as is and do further refactoring incrementally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
