vigyasharma commented on PR #13202: URL: https://github.com/apache/lucene/pull/13202#issuecomment-2032687387
> > `TimeLimitingBulkScorer` already optimizes for timeout check frequency outside of `QueryTimeout` impl > > Ahh nice catch! You mean something like: > > ```java > // counter is an integer initialized to 0 > return (counter++ == 100 && queryTimeout.shouldExit()) || collector.earlyTerminated(); > ``` > > in the `TimeLimitingKnnCollectorManager` itself? > > This makes sense to me, we can add this in a follow-up and even make the interval growing like [this commit](https://github.com/apache/lucene/commit/7ce9dbbf65e522f9b463b8518f247a3e7d6332ae)? Yes. Let's do it in a follow-up change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
