rmuir opened a new pull request, #13269:
URL: https://github.com/apache/lucene/pull/13269

   Currently, we depend upon a pre-COVID version of commons-codec (like several 
other dependencies, I am working the issues).
   
   Upgrade to 1.16.0.
   
   NOTE: I'm unable to upgrade to 1.16.1: it causes test failures. 
   
   
   ```
      $ ./gradlew -p lucene/analysis/phonetic test
      ...
      >     java.lang.ExceptionInInitializerError
      >         at 
[email protected]/org.apache.commons.codec.language.bm.Lang.<clinit>(Lang.java:108)
      >         at 
[email protected]/org.apache.commons.codec.language.bm.PhoneticEngine.<init>(PhoneticEngine.java:300)
      >         at 
[email protected]/org.apache.commons.codec.language.bm.PhoneticEngine.<init>(PhoneticEngine.java:276)
                ...
      >
      >         Caused by:
      >         java.lang.IllegalArgumentException: Unable to resolve required 
resource: org/apache/commons/codec/language/bm/ash_languages.txt
      >             at 
[email protected]/org.apache.commons.codec.Resources.getInputStream(Resources.java:38)
      >             at 
[email protected]/org.apache.commons.codec.language.bm.Languages.getInstance(Languages.java:254)
      >             at 
[email protected]/org.apache.commons.codec.language.bm.Languages.<clinit>(Languages.java:243)
   ```
   
   Seems some resources are missing from the jar or similar.
   I tried to investigate a bit, by looking at their source code changes from 
1.16.0 to 1.16.1, it is overwhelming, not exactly what I'd call a "patch" 
release :)
   
   
https://github.com/apache/commons-codec/compare/rel/commons-codec-1.16.0...rel/commons-codec-1.16.1
   
   Either way, that isn't to be fixed here, so let's at least move from a 2019 
version to a 2023 version. We can separately debug the 1.16.1 issue / report it 
to them / file a PR /etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to