kaivalnp commented on code in PR #13312:
URL: https://github.com/apache/lucene/pull/13312#discussion_r1568720556
##########
lucene/core/src/java/org/apache/lucene/search/TimeLimitingKnnCollectorManager.java:
##########
@@ -42,54 +42,62 @@ public KnnCollector newCollector(int visitedLimit,
LeafReaderContext context) th
if (queryTimeout == null) {
return collector;
}
- return new KnnCollector() {
- @Override
- public boolean earlyTerminated() {
- return queryTimeout.shouldExit() || collector.earlyTerminated();
- }
-
- @Override
- public void incVisitedCount(int count) {
- collector.incVisitedCount(count);
- }
-
- @Override
- public long visitedCount() {
- return collector.visitedCount();
- }
-
- @Override
- public long visitLimit() {
- return collector.visitLimit();
- }
-
- @Override
- public int k() {
- return collector.k();
- }
-
- @Override
- public boolean collect(int docId, float similarity) {
- return collector.collect(docId, similarity);
- }
-
- @Override
- public float minCompetitiveSimilarity() {
- return collector.minCompetitiveSimilarity();
- }
-
- @Override
- public TopDocs topDocs() {
- TopDocs docs = collector.topDocs();
-
- // Mark results as partial if timeout is met
- TotalHits.Relation relation =
- queryTimeout.shouldExit()
- ? TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO
- : docs.totalHits.relation;
-
- return new TopDocs(new TotalHits(docs.totalHits.value, relation),
docs.scoreDocs);
- }
- };
+ return new TimeoutingKnnCollector(collector);
+ }
+
+ class TimeoutingKnnCollector implements KnnCollector {
Review Comment:
Should we make this `TimeLimitingKnnCollector` for name parity with
`TimeLimitingKnnCollectorManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
