ChrisHegarty commented on code in PR #13308:
URL: https://github.com/apache/lucene/pull/13308#discussion_r1572273717
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java:
##########
@@ -302,7 +301,6 @@ private static VectorSimilarityFunction
getDistFunc(IndexInput input, byte b) th
List.of(
VectorSimilarityFunction.EUCLIDEAN,
VectorSimilarityFunction.DOT_PRODUCT,
- VectorSimilarityFunction.COSINE,
Review Comment:
++ The reason for the list here is exactly to support and allow such
evolution and separation from the enum ordinals. A null here trivially need to
a change of List implementation type. And tests need to be carefully updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
