boicehuang commented on code in PR #13306:
URL: https://github.com/apache/lucene/pull/13306#discussion_r1576153792
##########
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##########
@@ -177,7 +180,6 @@ public boolean test(LeafReaderContext context) {
* @lucene.experimental
*/
protected void onHit(Object readerCoreKey, Query query) {
- assert lock.isHeldByCurrentThread();
Review Comment:
I adjust `missCount` and `hitCount` to be `LongAdder` objects and get the
benchmark results as follows.
doc count | field cardinality | query point | baseline QPS | candidate QPS |
diff percentage
-- | -- | -- | -- | -- | --
30000000 | 10 | 1 | 2481 | 5102 | 105.6%
30000000 | 10 | 1 | 2481 | 4843 | 95.2% (using `LongAdder `)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
