uschindler commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1585152280


##########
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##########
@@ -171,14 +171,7 @@ public final float overheadRatio(int bitsPerValue) {
   }
 
   /** Simple class that holds a format and a number of bits per value. */
-  public static class FormatAndBits {
-    public final Format format;
-    public final int bitsPerValue;
-
-    public FormatAndBits(Format format, int bitsPerValue) {
-      this.format = format;
-      this.bitsPerValue = bitsPerValue;
-    }
+  public record FormatAndBits(Format format, int bitsPerValue) {
 
     @Override
     public String toString() {

Review Comment:
   do we need toString(), this one can be autogenerated, just the output is 
different.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to