dsmiley commented on code in PR #13327:
URL: https://github.com/apache/lucene/pull/13327#discussion_r1597469133
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##########
@@ -139,17 +148,38 @@ public FieldInfos(FieldInfo[] infos) {
this.softDeletesField = softDeletesField;
this.parentField = parentField;
- FieldInfo[] sortedFieldInfos = ArrayUtil.copyOfSubArray(infos, 0,
infos.length);
- Arrays.sort(sortedFieldInfos, (fi1, fi2) -> Integer.compare(fi1.number,
fi2.number));
- int maxFieldNumber = infos.length == 0 ? -1 :
sortedFieldInfos[infos.length - 1].number;
- // If there are many fields and the max field number is greater than twice
the number
- // of fields, then a map structure is more compact to store the by-number
mapping.
- byNumber =
- maxFieldNumber >= 2 * infos.length && maxFieldNumber >= 32
- ? new MapFieldInfoByNumber(infos)
- : new ArrayFieldInfoByNumber(infos, maxFieldNumber);
- // The iteration of FieldInfo is ordered by ascending field number.
- values =
Collections.unmodifiableCollection(Arrays.asList(sortedFieldInfos));
+ if (fieldNumberStrictlyAscending && maxFieldNumber == infos.length - 1) {
+ // The input FieldInfo[] contains all fields numbered from 0 to
infos.length - 1 and they are
+ // sorted, use it directly. This is an optimization when reading a
segment with all fields
+ // since the FieldInfo[] is sorted.
+ byNumber = infos; // We could copy the input array, but do we need to?
+ values = Arrays.asList(byNumber);
+ } else {
+ byNumber = new FieldInfo[maxFieldNumber + 1];
+ for (FieldInfo fieldInfo : infos) {
+ FieldInfo previous = byNumber[fieldInfo.number];
Review Comment:
Thanks. "previous" wasn't wrong, just ambiguous. I like "existing";
another possible name is "old".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
