ChrisHegarty commented on code in PR #13365:
URL: https://github.com/apache/lucene/pull/13365#discussion_r1598460737
##########
lucene/core/src/java/org/apache/lucene/util/quantization/QuantizedByteVectorValues.java:
##########
@@ -53,5 +53,5 @@ public final long cost() {
* @param query the query vector
* @return a {@link VectorScorer} instance
*/
- public abstract VectorScorer vectorScorer(float[] query) throws IOException;
+ public abstract VectorScorer scorer(float[] query) throws IOException;
Review Comment:
The javadoc should indicate that a null can be returned. And then, all
usage sites need to null check the return value, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
