zkendall commented on code in PR #13384:
URL: https://github.com/apache/lucene/pull/13384#discussion_r1606180243
##########
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighterStrictPhrases.java:
##########
@@ -183,13 +183,15 @@ public void testBasics() throws IOException {
}
public void testWithSameTermQuery() throws IOException {
Review Comment:
Edit existing test. The test was already testing having overlapping term and
phrase queries; however it didn't reproduce the bug until I expanded the
overlaps with multiple terms.
Without the fix, TestUnifiedHighlighterStrictPhrases fails like this
```
arrays first differed at element [0]; expected:<<b>Yin yang[
]loooooooooong</b>, <...> but was:<<b>Yin yang[</b> <b>]loooooooooong</b>, <...>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
