msfroh commented on issue #13393: URL: https://github.com/apache/lucene/issues/13393#issuecomment-2130092260
Is it fair to say that this change just brings `KnnVectorsFormat` in line with: 1. PostingsFormat: https://github.com/apache/lucene/blob/2d6ad2fee6dfd96388594f4de9b37c037efe8017/lucene/core/src/java/org/apache/lucene/codecs/PostingsFormat.java#L130 2. DocValuesFormat: https://github.com/apache/lucene/blob/2d6ad2fee6dfd96388594f4de9b37c037efe8017/lucene/core/src/java/org/apache/lucene/codecs/DocValuesFormat.java#L125 3. SortFieldProvider: https://github.com/apache/lucene/blob/2d6ad2fee6dfd96388594f4de9b37c037efe8017/lucene/core/src/java/org/apache/lucene/index/SortFieldProvider.java#L65 These other formats are dynamically pluggable, and this change is just making `KnnVectorsFormat` consistent with them, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
