stefanvodita commented on code in PR #13494:
URL: https://github.com/apache/lucene/pull/13494#discussion_r1642796846
##########
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java:
##########
@@ -154,7 +154,7 @@ public FacetResult getAllChildren(String dim, String...
path) throws IOException
final BytesRef term = docValues.lookupOrd(sparseCount.key);
labelValues.add(new LabelAndValue(term.utf8ToString(), count));
}
- } else {
Review Comment:
What if instead of adding this condition, we removed the if statement at
[line
116](https://github.com/apache/lucene/blob/d29c57e50c38c1a090395644165b34f5191246b8/lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java#L116)?
That fits what we do with other facets (e.g.
[`TaxonomyFacets`](https://github.com/apache/lucene/blob/d29c57e50c38c1a090395644165b34f5191246b8/lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java#L117))
and it makes it so we don't have to be extra careful with this case in the
future and risk someone missing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
