epotyom commented on code in PR #13702:
URL: https://github.com/apache/lucene/pull/13702#discussion_r1740604447
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java:
##########
@@ -344,31 +331,30 @@ public <R> ConcurrentDrillSidewaysResult<R> search(
// Main query
FacetsCollectorManager drillDownFacetsCollectorManager =
createDrillDownFacetsCollectorManager();
- final CollectorOwner<?, ?> mainCollectorOwner;
+ final CollectorManager<?, ?> mainCollectorManager;
if (drillDownFacetsCollectorManager != null) {
// Make sure we populate a facet collector corresponding to the base
query if desired:
- mainCollectorOwner =
- new CollectorOwner<>(
- new MultiCollectorManager(drillDownFacetsCollectorManager,
hitCollectorManager));
+ mainCollectorManager =
+ new MultiCollectorManager(drillDownFacetsCollectorManager,
hitCollectorManager);
} else {
- mainCollectorOwner = new CollectorOwner<>(hitCollectorManager);
+ mainCollectorManager = hitCollectorManager;
}
// Drill sideways dimensions
- final List<CollectorOwner<?, ?>> drillSidewaysCollectorOwners;
+ final List<CollectorManager<FacetsCollector, FacetsCollector>>
drillSidewaysCollectorManagers;
if (query.getDims().isEmpty() == false) {
- drillSidewaysCollectorOwners = new ArrayList<>(query.getDims().size());
+ drillSidewaysCollectorManagers = new ArrayList<>(query.getDims().size());
for (int i = 0; i < query.getDims().size(); i++) {
- drillSidewaysCollectorOwners.add(
- new CollectorOwner<>(createDrillSidewaysFacetsCollectorManager()));
+
drillSidewaysCollectorManagers.add(createDrillSidewaysFacetsCollectorManager());
}
} else {
- drillSidewaysCollectorOwners = null;
+ drillSidewaysCollectorManagers = null;
}
// Execute query
+ final Result<?, ?> result;
Review Comment:
Nice catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
