javanna commented on issue #11754: URL: https://github.com/apache/lucene/issues/11754#issuecomment-2328396050
You are correct @rmuir ! In my case, `mulFactor` is `1024`. My branch makes it even more likely to go out of heap space, because it may create more slices to be searched concurrently, and each slice gets a separate collector with a separate queue of that size. We could disable query concurrency for this test, or work on limiting the number of slices. On the other hand, I don't understand the purpose of `1000 * mulFactor`. If I use `mulFactor` as the size of the queue, the test still succeeds and it no longer goes out of heap for my failing seed. Maybe that's a reasonable fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
