dweiss commented on issue #13719:
URL: https://github.com/apache/lucene/issues/13719#issuecomment-2332544468
I think this logic is flawed:
```
// git ignores any folders which are empty (this includes folders
with recursively empty sub-folders).
def untrackedNonEmptyFolders = status.untrackedFolders.findAll {
path ->
File location = file("${rootProject.projectDir}/${path}")
boolean hasFiles = false
Files.walkFileTree(location.toPath(), new
SimpleFileVisitor<Path>() {
@Override
FileVisitResult visitFile(Path file, BasicFileAttributes attrs)
throws IOException {
hasFiles = true
// Terminate early.
return FileVisitResult.TERMINATE
}
})
return hasFiles
}
```
we shouldn't do anything about untrackedFolders. Looking at jgit's
implementation, I don't even see the reason it's there and I can't remember why
I (or somebody else) added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
