javanna commented on code in PR #13737: URL: https://github.com/apache/lucene/pull/13737#discussion_r1748020468
########## lucene/facet/src/java/org/apache/lucene/facet/FacetsCollectorManager.java: ########## @@ -54,4 +79,167 @@ public ReducedFacetsCollector(final Collection<FacetsCollector> facetsCollectors facetsCollector -> matchingDocs.addAll(facetsCollector.getMatchingDocs())); } } + + /** Utility method, to search and also collect all hits into the provided {@link Collector}. */ Review Comment: good catch, I missed that. Will backport your commit! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org