romseygeek commented on code in PR #13735:
URL: https://github.com/apache/lucene/pull/13735#discussion_r1750455113
##########
lucene/monitor/src/java/org/apache/lucene/monitor/CollectingMatcher.java:
##########
@@ -37,7 +38,7 @@ abstract class CollectingMatcher<T extends QueryMatch>
extends CandidateMatcher<
@Override
public void matchQuery(final String queryId, Query matchQuery, Map<String,
String> metadata)
throws IOException {
- searcher.search(matchQuery, new MatchCollector(queryId, scoreMode));
+ searcher.search(matchQuery, CollectorManager.wrap(new
MatchCollector(queryId, scoreMode)));
Review Comment:
I guess you *could* call it with an externally built searcher, but it
wouldn't be very useful as the whole point is that it's a searcher over a batch
of documents submitted to the monitor for checking. It's public to allow
clients to build wrapping matchers.
There may be a nicer way to do this though, let me experiment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
