rmuir commented on code in PR #13757:
URL: https://github.com/apache/lucene/pull/13757#discussion_r1755644871
##########
lucene/core/src/java/org/apache/lucene/search/similarities/Similarity.java:
##########
@@ -111,7 +133,17 @@ protected Similarity() {}
* @param state current processing state for this field
* @return computed norm value
*/
- public abstract long computeNorm(FieldInvertState state);
+ public long computeNorm(FieldInvertState state) {
Review Comment:
I think it would be good to document what the default implementation is
doing? e.g. at least it should state that it uses `SmallFloat.intToByte4` lossy
compression to encode the length as a single byte?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
