shubhamvishu commented on PR #13743: URL: https://github.com/apache/lucene/pull/13743#issuecomment-2346624909
Yes, usually we do that but in this case there is a catch. This test ONLY fails when the generated points are non collinear(as expected) but the `area == 0` ([checked in this condition](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/geo/Tessellator.java#L1320-L1327)), which makes it throw the error of `at least three non-collinear points required`. If the `area > 0` then this test runs as expected without any issues. So with comparison to 0 we would rightly avoid only those cases where it actually trips but, epsilon might cause it to simply skip more cases where test could have run successfully. Moreover, as the generated coordinates have extremely small absolute values and close distance (eg : SomeNumE-84, SomeNumE-240 etc), its tricky to find some sane epsilon in this case (which would only skip running the test unnecessarily). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
