jpountz commented on code in PR #13779:
URL: https://github.com/apache/lucene/pull/13779#discussion_r1758220291
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##########
@@ -361,33 +385,46 @@ private MergedByteVectorValues(List<ByteVectorValuesSub>
subs, MergeState mergeS
totalSize += sub.values.size();
}
size = totalSize;
- docId = -1;
}
@Override
- public byte[] vectorValue() throws IOException {
- return current.values.vectorValue();
+ public byte[] vectorValue(int ord) throws IOException {
+ return current.values.vectorValue(current.values.iterator().index());
Review Comment:
This part feels a bit hacky, could we instead merge the ord->vector mappings
of the various vector values by concatenating them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
