benwtrent commented on PR #13779: URL: https://github.com/apache/lucene/pull/13779#issuecomment-2360711342
The dictionary idea is OK, but I still don't see how it removes `copy()`. Besides the caching of values, copy gives us multi-threaded safety by copying the underlying index readers. Otherwise we are using the same reader between threads. For concurrent merging of graphs, this is important. I agree, any further refactoring should be done in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
