benwtrent commented on code in PR #13826:
URL: https://github.com/apache/lucene/pull/13826#discussion_r1776903327
##########
lucene/core/src/java/org/apache/lucene/search/knn/MultiLeafKnnCollector.java:
##########
@@ -58,7 +58,32 @@ public final class MultiLeafKnnCollector implements
KnnCollector {
*/
public MultiLeafKnnCollector(
int k, BlockingFloatHeap globalSimilarityQueue, AbstractKnnCollector
subCollector) {
- this.greediness = DEFAULT_GREEDINESS;
+ this(k, DEFAULT_GREEDINESS, DEFAULT_INTERVAL, globalSimilarityQueue,
subCollector);
+ }
+
+ /**
+ * Create a new MultiLeafKnnCollector.
+ *
+ * @param k the number of neighbors to collect
+ * @param greediness the greediness of the global search
+ * @param interval (by number of collected values) the interval to
synchronize the local and
+ * global queues
+ * @param globalSimilarityQueue the global queue of the highest similarities
collected so far
+ * @param subCollector the local collector
+ */
+ public MultiLeafKnnCollector(
+ int k,
+ float greediness,
+ int interval,
+ BlockingFloatHeap globalSimilarityQueue,
+ AbstractKnnCollector subCollector) {
+ if (greediness <= 0 || greediness > 1) {
Review Comment:
I am fine with allow `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
