bruno-roustant commented on code in PR #13876:
URL: https://github.com/apache/lucene/pull/13876#discussion_r1793571950
##########
lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntObjectHashMap.java:
##########
@@ -66,10 +69,8 @@ private static void assertSortedListEquals(int[] array,
int... elements) {
}
/** Check if the array's content is identical to a given sequence of
elements. */
- private static void assertSortedListEquals(Object[] array, Object...
elements) {
- assertEquals(elements.length, array.length);
- Arrays.sort(array);
- assertArrayEquals(elements, array);
+ private static void assertSortedListEquals(List<Object> array, Object...
elements) {
+ Assert.assertEquals(array.stream().sorted().toList(),
Arrays.asList(elements));
Review Comment:
Should the params order be swapped to have the expected first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
