uschindler commented on PR #13907: URL: https://github.com/apache/lucene/pull/13907#issuecomment-2413504761
> > The latter check is still there, so maybe we can clean this up, too. > > OK I'll do this. You basically restored the original state. Thanks. Possibly we could still implement is like it was done recently. My conmment was more about removing the null check and making the mapper function return `int`. The new / restored code has the problem that we can't restore the read advise when we change it back to NORMAL after merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
