vigyasharma commented on PR #13395: URL: https://github.com/apache/lucene/pull/13395#issuecomment-2497070379
> I am nervous about this change -- altering the very widely used `Scorer` API to express whether it matches all documents feels invasive. +1. I wonder how widely useful a `matchesAll()` API in the scorer would be. The only place that comes to mind is dropping a segment with all deleted docs (i.e. this PR). For search scenarios, we'd need to iterate over the scorer iterator; and the `cost()` API is good enough for estimation use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
