msokolov commented on code in PR #14019:
URL: https://github.com/apache/lucene/pull/14019#discussion_r1865909044
##########
lucene/core/src/java/org/apache/lucene/index/IndexCommit.java:
##########
@@ -25,9 +25,9 @@
* Expert: represents a single commit into an index as seen by the {@link
IndexDeletionPolicy} or
* {@link IndexReader}.
*
- * <p>Changes to the content of an index are made visible only after the
writer who made that change
- * commits by writing a new segments file (<code>segments_N</code>). This
point in time, when the
- * action of writing of a new segments file to the directory is completed, is
an index commit.
+ * <p>Changes to the content of an index are made visible only after the
writer which made that
+ * change commits by writing a new segments file (<code>segments_N</code>).
This point in time, when
Review Comment:
heh, I *did* read this as if the writer was a human; not sure why! I still
think `that` is better than `which` not sure why exactly. I think this page
describes the difference well: https://www.dictionary.com/e/that-vs-which/ --
if the restrictive clause is essential to the meaning of the sentence, as it is
here, we use `that`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
