rmuir commented on code in PR #14326:
URL: https://github.com/apache/lucene/pull/14326#discussion_r1984161499
##########
dev-tools/scripts/create_line_file_docs.py:
##########
@@ -60,7 +60,7 @@ def compress_with_seek_points(file_name_in, file_name_out,
num_seek_points):
break
bytes_in_chunk += len(line)
- f_out.write(line) # false positive in python's crazy typing # pyright:
ignore[reportArgumentType]
+ f_out.write(line)
Review Comment:
IIRC, it seems like a corner-case bug in the typechecker. typechecker has a
grid of options:
https://docs.basedpyright.com/latest/configuration/config-files/#diagnostic-settings-defaults
And in the process of getting started here, lots of booleans were being
flipped on and off. I think it led to a false positive given the exact
circumstances of booleans (ignore this problem, but fail on that problem, etc):
basically we are asking it to validate within a broken/incoherent type system.
Once enough stuff got fixed, then strictness was enabled which allows things
to work smoothly. This is just my read on what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
