jpountz commented on code in PR #14312:
URL: https://github.com/apache/lucene/pull/14312#discussion_r1986310180
##########
lucene/core/src/java/org/apache/lucene/search/DenseConjunctionBulkScorer.java:
##########
@@ -128,6 +128,16 @@ private void scoreWindowUsingBitSet(
assert windowMatches.scanIsEmpty();
assert clauseWindowMatches.scanIsEmpty();
+ windowIterators.clear();
+ for (DocIdSetIterator iterator : iterators) {
+ // Skip iterators that fully match the window
+ if (iterator.docID() > windowBase || iterator.peekNextNonMatchingDocID()
< windowMax) {
+ windowIterators.add(iterator);
+ }
+ }
+ // Note: iterators may be empty!
+ iterators = windowIterators;
Review Comment:
Ahhh right, thanks for catching. I did a large refactoring but I made sure
to fix this, and added tests to DenseConjunctionBulkScorer that should catch
such problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
