uschindler commented on issue #14999: URL: https://github.com/apache/lucene/issues/14999#issuecomment-3131045375
In 10.x we no longer have old MappedByteBuffers for mmap. This was removed when Lucene 10 moved to Java 21. We still have the special extra source set as the API for MemorySegments is preview, but it is always used: https://github.com/apache/lucene/pull/13146 I am still not sure if we should really remove the parent tracking without reviewing all use cases for it. I am not sure what else it is required for. And therefore all childs need tracking with no exceptions! We should review all tests checking this and understand why they do it. We should really figure out why it is used. Wasn't it also used for tracking relationship of composite readers? If you close a child of a composite reader it breaks search, too. In general I don't understand why Opensearch wants to wrap IndexReaders per request. Making it non#closeable could also be done globally (and only the index reopener thread has the power to close them). On the other hand if a plugin closes a reader it breaks search. Yes, but any plugin directly interacting with index readers can break Opensearch. Who cares - uninstall plugin and fine. I see no reason to support this untypical use of readers. It is not a plugin safety issue. Every plugin that misbehaves can stop your server in hundreds of ways -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
