uschindler commented on issue #14999: URL: https://github.com/apache/lucene/issues/14999#issuecomment-3131649062
The PR looks fine. But I would only apply it to main branch and let it bake there for a while. I'd like to do some more checks in history to see if there were other use-cases except MMapDirectory. The original code is "normally" never ever a problem because there is no contention - you create wrapped readers only when you construct the reader structure, e.g., when you reopen readers. All the time wrapping readers from different threads is a no-go and should be avoided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
