thecoop commented on code in PR #15040: URL: https://github.com/apache/lucene/pull/15040#discussion_r2263129530
########## lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java: ########## @@ -131,6 +132,57 @@ public void testWithNormal() throws Exception { } } + public void testAdviseByContextFunc() throws IOException { + var func = MMapDirectory.ADVISE_BY_CONTEXT; + var flush = IOContext.flush(new FlushInfo(1, 2)); + var merge = IOContext.merge(new MergeInfo(1, 2, true, 4)); + var random = new DefaultIOContext(DataAccessHint.RANDOM); Review Comment: Can we iterate over the various hint type arrays rather than hard-coding so this doesn't need to be modified if more are added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org