tflobbe commented on PR #15221: URL: https://github.com/apache/lucene/pull/15221#issuecomment-3339868149
Added an implementation using a dedicated collector for DrillSideways that can bubble up the early termination. This works for the sequential case, but it won't work for the concurrent case, since in concurrent, we are collecting directly with the sideways collector. For the concurrent case, each sideways facet collector should early terminate on it's own. A FacetsCollector that early terminates on it's own is something that would even work today without any changes, it's just sometimes difficult to have FacetsCollector know when to terminate, depending on the logic that's triggering that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
