benwtrent commented on code in PR #15502:
URL: https://github.com/apache/lucene/pull/15502#discussion_r2619758511
##########
lucene/core/src/test/org/apache/lucene/search/TestFilterWeight.java:
##########
@@ -36,28 +35,6 @@ private void implTestDeclaredMethodsOverridden(Class<?>
superClass, Class<?> sub
final int modifiers = superClassMethod.getModifiers();
if (Modifier.isFinal(modifiers)) continue;
if (Modifier.isStatic(modifiers)) continue;
- if (Arrays.asList("bulkScorer",
"count").contains(superClassMethod.getName())) {
- try {
- final Method subClassMethod =
- subClass.getDeclaredMethod(
- superClassMethod.getName(),
superClassMethod.getParameterTypes());
- fail(
- subClass
- + " must not override\n'"
- + superClassMethod
- + "'"
- + " but it does override\n'"
- + subClassMethod
- + "'");
- } catch (NoSuchMethodException _) {
- /* FilterWeight must not override the bulkScorer method
- * since as of July 2016 not all deriving classes use the
- * {code}return in.bulkScorer(content);{code}
- * implementation that FilterWeight.bulkScorer would use.
- */
- continue;
- }
- }
Review Comment:
Did you also delegate bulkScorer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
