mikemccand commented on PR #15341:
URL: https://github.com/apache/lucene/pull/15341#issuecomment-3714615676
I sort of wonder if CFS is really ever needed anymore? It was added long
ago to limit number of open file handles Lucene uses, back when OS's placed
severe (1024?) limits on how many open files one process is allowed to have.
(Hmm digging with Gemini a bit it seems the soft limit on open file
descriptors for one process (`nofile`) is often still 1024. So I guess we
still need CFS, and probably should keep it enabled by default...)
How many files per segment do we create these days? Looking at last night's
index from nightly benchy:
```
-rw-r--r-- 1 mike mike 327 Jan 6 05:55 _32.fdm
-rw-r--r-- 1 mike mike 48734305 Jan 6 05:55 _32.fdt
-rw-r--r-- 1 mike mike 12998 Jan 6 05:55 _32.fdx
-rw-r--r-- 1 mike mike 3460 Jan 6 06:10 _32.fnm
-rw-r--r-- 1 mike mike 48665081 Jan 6 05:56 _32.kdd
-rw-r--r-- 1 mike mike 177719 Jan 6 05:56 _32.kdi
-rw-r--r-- 1 mike mike 326 Jan 6 05:56 _32.kdm
-rw-r--r-- 1 mike mike 899803529 Jan 6 05:56 _32_Lucene104_0.doc
-rw-r--r-- 1 mike mike 1365783724 Jan 6 05:56 _32_Lucene104_0.pos
-rw-r--r-- 1 mike mike 112 Jan 6 05:56 _32_Lucene104_0.psm
-rw-r--r-- 1 mike mike 167569320 Jan 6 05:56 _32_Lucene104_0.tim
-rw-r--r-- 1 mike mike 3249762 Jan 6 05:56 _32_Lucene104_0.tip
-rw-r--r-- 1 mike mike 855 Jan 6 05:56 _32_Lucene104_0.tmd
-rw-r--r-- 1 mike mike 345629552 Jan 6 05:56 _32_Lucene90_0.dvd
-rw-r--r-- 1 mike mike 6318 Jan 6 05:56 _32_Lucene90_0.dvm
-rw-r--r-- 1 mike mike 20390015076 Jan 6 06:10
_32_Lucene99HnswVectorsFormat_0.vec
-rw-r--r-- 1 mike mike 348467 Jan 6 06:10
_32_Lucene99HnswVectorsFormat_0.vem
-rw-r--r-- 1 mike mike 145 Jan 6 06:10
_32_Lucene99HnswVectorsFormat_0.vemf
-rw-r--r-- 1 mike mike 422405978 Jan 6 06:10
_32_Lucene99HnswVectorsFormat_0.vex
-rw-r--r-- 1 mike mike 9956121 Jan 6 05:55 _32.nvd
-rw-r--r-- 1 mike mike 139 Jan 6 05:55 _32.nvm
-rw-r--r-- 1 mike mike 718 Jan 6 06:10 _32.si
```
22! Even more reason to keep CFS enabled by default ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
