uschindler commented on code in PR #15341: URL: https://github.com/apache/lucene/pull/15341#discussion_r2668016217
########## lucene/CHANGES.txt: ########## @@ -314,6 +314,9 @@ Other * GITHUB#15513: Update documentation in DefaultBloomFilterFactory to reflect changes made in GITHUB#11900 (Greg Miller) +* GITHUB#15341: Align float vectors on disk to 64 bytes, for optimal performance on Arm Neoverse + machines. (Mike McCandless, Kaival Parikh) Review Comment: I would keep the message as is. Maybe just add CFS files, too. Because it is different changes. Originally we aligned all non-byte[] vectors in vec files to 64 bytes, the CFS was just a followup requirement. Generally I think we should at some point think about aligning CFS sub-file to disk blocks, because this would allow to page in/out pages from CFS files exactly like normal files without any overhead. This would make CFS files zero overhead while reading. But that's a different discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
