blerer commented on issue #15452: URL: https://github.com/apache/lucene/issues/15452#issuecomment-3723211754
I pushed a new version of the patch where I have attempted to cover all the Filter classes. as I am new with the code base I might have missed some. @dweiss I ran into 4 test issues when I changed the logic. The most surprising from my point of view were linked to `FilterWeight.count`. It turned out that `TermWeight.count` is ignored by `ToChildBlockJoinQuery$ToChildBlockJoinWeight` and `GlobalOrdinalsWithScoreQuery$W`. The patch made the code work as it used to but there is probably some investigation to be done on what is the correct implementation. The 2 other issues were test related. Some method mock implementations were ignored. It is difficult to say if it was on purpose or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
