dweiss commented on code in PR #15469:
URL: https://github.com/apache/lucene/pull/15469#discussion_r2676130582
##########
lucene/core/src/java/org/apache/lucene/search/BooleanScorerSupplier.java:
##########
@@ -482,14 +482,19 @@ private Scorer req(
// to prevent score() from being propagated
return new FilterScorer(req) {
@Override
- public float score() throws IOException {
+ public float score() {
return 0f;
}
@Override
- public float getMaxScore(int upTo) throws IOException {
+ public float getMaxScore(int upTo) {
return 0f;
}
+
+ @Override
+ public int advanceShallow(int target) {
+ return DocIdSetIterator.NO_MORE_DOCS;
+ }
Review Comment:
Ok, I think I understand why this override needs to be here (along with
those other scoring methods). It's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]