benwtrent commented on PR #15556: URL: https://github.com/apache/lucene/pull/15556#issuecomment-3740150918
> If hotCounter < 1000, we consider the index cold and continue prefetching. I am not sure how/if this approach would transfer to hardware memory decisions? What do you think? For sure, dynamic pre-fetching like this isn't directly assignable to underlying hardware. It does seem like something that is the complete ownership of the directory implementation and leaking configuration for a "directory optimization" to things like `createWeight` is a huge red flag. It would take some convincing for me to consider this API as acceptable. Maybe I am missing some complexity hidden that makes this impossible to implement at the directory level. Again, I also don't think a new "top level" thing needs to be added to ANY directory/indexinput either. I am suggesting that for where this is desired, the underlying directory/indexinput is wrapped and calls delegated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
