churromorales commented on PR #15620: URL: https://github.com/apache/lucene/pull/15620#issuecomment-3887288825
@benwtrent of course, you make a great point. This was something I was hoping that would be brought up during a PR review actually :). It is one of those things where I made a decision and I'm not necessarily sure if it was the right one. Let me update the description to reflect what I did, and what is possible in terms of trade-offs. TLDR i don't handle deletes during regular merges (although I could, for us it wasn't worth the extra I/O, but for upstream I wasn't totally sure. `IndexWriter.forceMergeDeletes()` works as expected, but there are a couple of caveats, want me to update the PR description or should we just have this discussion in thread? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
