countmdm commented on PR #15699: URL: https://github.com/apache/lucene/pull/15699#issuecomment-3892950057
> You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196 > > This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both. Ok, I see. The CHANGES.txt file on the above link has a "Lucene 10.5.0" section. However, on my local main branch, this file only has "Lucene 11.0" and "Lucene 10.4.0" sections. > You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196 > > This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both. Oh, ok, sorry about myself being dumb, I forgot to update my Lucene fork :) Now I see that there is already a proper entry in CHANGES.txt for #15637 . So closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
